Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc for generation with multiple blocks of Api #552

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Doc for generation with multiple blocks of Api #552

merged 2 commits into from
Jul 6, 2022

Conversation

dbsxdbsx
Copy link
Contributor

@dbsxdbsx dbsxdbsx commented Jul 6, 2022

what's new

Mention the new example in Section 3.Features.
Add a new doc for detailed explanation on why and how to generate Api within multiple blocks(files).

related pr

#516
#527

related issue

#511

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jul 6, 2022

@all-contributors please add @dbsxdbsx for doc

@allcontributors
Copy link
Contributor

@fzyzcjy

I've put up a pull request to add @dbsxdbsx! 🎉

@fzyzcjy fzyzcjy merged commit d89987f into fzyzcjy:master Jul 6, 2022
@fzyzcjy
Copy link
Owner

fzyzcjy commented Jul 6, 2022

Good work! LGTM, except some phrasing, which I will modify after merging.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jul 6, 2022

Btw, https://app.grammarly.com is quite helpful to check and improve grammar automatically.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jul 6, 2022

/cc @Desdaemon who wrote that wonderful tutorial part

@dbsxdbsx
Copy link
Contributor Author

dbsxdbsx commented Jul 6, 2022

Good work! LGTM, except some phrasing, which I will modify after merging.

By the way, I forgot how flutter_rust_bridge solves the explicit and implicit APIs respectively.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jul 6, 2022

what is explicit and implicit api?

@dbsxdbsx
Copy link
Contributor Author

dbsxdbsx commented Jul 6, 2022

what is explicit and implicit api?

If API is defined by users, it is explicit, others like new_uint8_list are implicit API. Frb would throw panic with conflict on explicit API, but no warning but automatically add suffix starting from 0 to avoid implicit API conflict.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jul 6, 2022

Ah, those are in the code details and I also do not remember very clearly currently.

I guess it is by simple string manipulation without fancy data structures.

Feel free to refactor them and PR!

@Desdaemon
Copy link
Contributor

Great writeup @dbsxdbsx. I'm thinking whether it would be fruitful to pursue a crate-wide, explicit declaration process a la wasm_bindgen, which could solve a lot of the problems described here.

@dbsxdbsx
Copy link
Contributor Author

dbsxdbsx commented Jul 6, 2022

Great writeup @dbsxdbsx. I'm thinking whether it would be fruitful to pursue a crate-wide, explicit declaration process a la wasm_bindgen, which could solve a lot of the problems described here.

I have no idea what "a crate-wide, explicit declaration process" means here. But I guess it is something related to support for the web platform, right?

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jul 6, 2022

I am not sure, I guess it may be another toml configuration file specifying things instead of using command-line?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants