Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI versions #2495

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

satvikpendem
Copy link
Contributor

Changes

Continuation of CI issues from #2488

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@satvikpendem
Copy link
Contributor Author

@fzyzcjy looks like same bad exit code issues here too, with just the CI update

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jan 13, 2025

Hmm, maybe we can look at logs above "bad exit code" line. For example, looks like some are just git diff that can be quickly fixed, e.g.

image

For this, looks like we need to upgrade android version according to the hint:

image

etc

@satvikpendem
Copy link
Contributor Author

Thanks, is there a way to force the git diff to pass? Looks like it's exiting if the new version for dependencies is not matching the old one so how do we tell it to prefer the newer version?

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jan 13, 2025

is there a way to force the git diff to pass?

I guess just to apply the git diff. Either by running command locally, or copy-paste the git diff section in the CI output to a local file and do git apply the patch.

@satvikpendem
Copy link
Contributor Author

satvikpendem commented Jan 14, 2025

Thanks, I was unfamiliar with git diff and git apply as I never had those sorts of test failures before so I'm working on updating the diffs now.

Getting some errors on the Android side, do you know anything about this? I think the Java version is still 1.8, should we upgrade?

'compileDebugJavaWithJavac' task (current target is 1.8) and 'compileDebugKotlin' task (current target is 17) jvm target compatibility should be set to the same Java version.

Also this on the native side: Could not find a command named "C:\hostedtoolcache\windows\dart\3.6.0\x64\bin\snapshots\frontend_server.dart.snapshot".

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jan 15, 2025

I think the Java version is still 1.8, should we upgrade?

If upgrade solves the problem then I guess it is OK.

@satvikpendem
Copy link
Contributor Author

Would you mind taking a look at why the rest are failing? I fixed what I can but I don't understand why they'd suddenly start failing when it seems they passed just fine before.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jan 16, 2025

Quickly glanced:

image

Weird, leave it there and I will do it last.

image

looks like need to do like #2493 (comment) to the example packages (as well as the example templates).

image

Try to lower the versions in pubspec.lock of packages mentioned in the error

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.25%. Comparing base (990bc14) to head (0718cb5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2495      +/-   ##
==========================================
- Coverage   98.99%   91.25%   -7.74%     
==========================================
  Files         475      471       -4     
  Lines       20106    19768     -338     
==========================================
- Hits        19903    18040    -1863     
- Misses        203     1728    +1525     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants