-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI versions #2495
base: master
Are you sure you want to change the base?
Update CI versions #2495
Conversation
@fzyzcjy looks like same bad exit code issues here too, with just the CI update |
Thanks, is there a way to force the git diff to pass? Looks like it's exiting if the new version for dependencies is not matching the old one so how do we tell it to prefer the newer version? |
I guess just to apply the git diff. Either by running command locally, or copy-paste the git diff section in the CI output to a local file and do |
Thanks, I was unfamiliar with git diff and git apply as I never had those sorts of test failures before so I'm working on updating the diffs now. Getting some errors on the Android side, do you know anything about this? I think the Java version is still 1.8, should we upgrade?
Also this on the native side: |
If upgrade solves the problem then I guess it is OK. |
1d81cc4
to
ac41c0d
Compare
Would you mind taking a look at why the rest are failing? I fixed what I can but I don't understand why they'd suddenly start failing when it seems they passed just fine before. |
Quickly glanced: Weird, leave it there and I will do it last. looks like need to do like #2493 (comment) to the example packages (as well as the example templates). Try to lower the versions in pubspec.lock of packages mentioned in the error |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2495 +/- ##
==========================================
- Coverage 98.99% 91.25% -7.74%
==========================================
Files 475 471 -4
Lines 20106 19768 -338
==========================================
- Hits 19903 18040 -1863
- Misses 203 1728 +1525 ☔ View full report in Codecov by Sentry. |
Changes
Continuation of CI issues from #2488
Checklist
./frb_internal precommit --mode slow
(orfast
) is run (it internal runs code generator, does auto formatting, etc)../website
folder) are updated.Remark for PR creator
./frb_internal --help
shows utilities for development.