Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call toolchain version with fvm support #2395

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

SirKrlos
Copy link

@SirKrlos SirKrlos commented Nov 6, 2024

Changes

Fix call dart/flutter toolchain --version with fvm support.

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

Copy link

welcome bot commented Nov 6, 2024

Hi! Thanks for opening this pull request! 😄

@SirKrlos
Copy link
Author

SirKrlos commented Nov 6, 2024

Test performed in an environment with only the installed fvm, without the global version of the Flutter in the system.

Preview of error before the correction below:
$ flutter_rust_bridge_codegen generate
[2024-11-06T07: 52: 38.764Z WARN /home/usertest/.cargo/registry/src/index.crates.io-6f17d22bba15001f/flutter_rust_bridge_codegen-2.6.0/src/library/commands/command_runner.rs:153] command="sh" "-c" ""flutter" "--version"" stdout= stderr=sh: linha 1: flutter: command not found
Error: Dart/Flutter Toolchain Not Available

Preview of the result after correction:
$ flutter_rust_bridge_codegen generate
[2.0s] Parse ⠂
└── [2.1s] Cargo expand & syn parse ⠄

@fzyzcjy
Copy link
Owner

fzyzcjy commented Nov 6, 2024

Great job!

@fzyzcjy fzyzcjy merged commit 068b097 into fzyzcjy:master Nov 6, 2024
135 checks passed
Copy link

welcome bot commented Nov 6, 2024

Hi! Congrats on merging your first pull request! 🎉

@fzyzcjy
Copy link
Owner

fzyzcjy commented Nov 6, 2024

@all-contributors please add @SirKrlos for code

Copy link
Contributor

@fzyzcjy

I've put up a pull request to add @SirKrlos! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants