-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use @generated in files to follow rustfmt #2263
Conversation
Hi! Thanks for opening this pull request! 😄 |
Good job! Ready to merge after CI is green :) For this simple PR, you can also manually copy and apply the CI failures. |
8d5a139
to
49baa4d
Compare
(For the last errors, I guess also just copy-paste and execute that patch. Looks like a spacing error) |
Thanks! My editor removed some trailing whitespace. I'm not sure exactly why the trailing whitespace is generated, otherwise I'd prevent that instead, but I couldn't figure it out. |
You are welcome!
I guess it is because rust formatter does not auto remove it (kind of shortcoming I guess)... |
b5fed79
to
f3ac09d
Compare
Oops, reverted a bit too much! |
Hi! Congrats on merging your first pull request! 🎉 |
@all-contributors please add @atezet for code |
I've put up a pull request to add @atezet! 🎉 |
Changes
Generated Rust files should include
@generated
in the first few lines. See https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#format_generated_filesChecklist
./frb_internal precommit --mode slow
(orfast
) is run (it internal runs code generator, does auto formatting, etc)../website
folder) are updated.Remark for PR creator
./frb_internal --help
shows utilities for development.