Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation with direct access to Android context #1881

Merged

Conversation

debanjanbasu
Copy link
Contributor

Changes

#1868

@fzyzcjy - adding in the documentation, for the help of others when they might require.

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

Copy link

welcome bot commented Apr 12, 2024

Hi! Thanks for opening this pull request! 😄

@fzyzcjy
Copy link
Owner

fzyzcjy commented Apr 12, 2024

Good job! I will merge and then slighly move it (e.g. maybe to a separate doc)

@fzyzcjy
Copy link
Owner

fzyzcjy commented Apr 12, 2024

@all-contributors please add @debanjanbasu for doc

Copy link
Contributor

@fzyzcjy

I've put up a pull request to add @debanjanbasu! 🎉

@fzyzcjy fzyzcjy merged commit 207d2bb into fzyzcjy:master Apr 12, 2024
88 of 94 checks passed
Copy link

welcome bot commented Apr 12, 2024

Hi! Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants