Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate generated definitions from implementations #298

Closed
fzyzcjy opened this issue Jan 10, 2022 · 2 comments
Closed

Separate generated definitions from implementations #298

fzyzcjy opened this issue Jan 10, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jan 10, 2022 •
edited
Loading

Currently, the definitions and implementations are all in bridge_generated.dart. If we separate it, the definitions will not import anything like dart:ffi so definitions can be used in the Web platform (though implementations will not yet). This at least will allow us to compile the code (though not running yet).

Will do this shortly.
@fzyzcjy fzyzcjy added the enhancement New feature or request label Jan 10, 2022
fzyzcjy added a commit that referenced this issue Jan 11, 2022
@fzyzcjy
add doc for #298 (to be implemented)
2918ac2
fzyzcjy added a commit that referenced this issue Jan 11, 2022
@fzyzcjy
Separate generated definitions from implementations (not tested) #298
c9a2262
@fzyzcjy
Copy link
Owner Author

fzyzcjy commented Jan 11, 2022

done. will publish a new version shortly.

@fzyzcjy fzyzcjy closed this as completed Jan 11, 2022
@github-actions
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fzyzcjy