fix ci

fzyzcjy · Oct 25, 2022 · dff4703 · dff4703
1 parent bdce8aa
commit dff4703
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 19 deletions.
diff --git a/all_lint_rules.yaml b/all_lint_rules.yaml
@@ -8,7 +8,6 @@ linter:
     - always_use_package_imports
     - annotate_overrides
     - avoid_annotating_with_dynamic
-    - avoid_as
     - avoid_bool_literals_in_conditional_expressions
     - avoid_catches_without_on_clauses
     - avoid_catching_errors

diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -40,10 +40,6 @@ linter:
     # and `@required Widget child` last.
     always_put_required_named_parameters_first: false
 
-    # `as` is not that bad (especially with the upcoming non-nullable types).
-    # Explicit exceptions is better than implicit exceptions.
-    avoid_as: false
-
     # This project doesn't use Flutter-style todos
     flutter_style_todos: false
 

diff --git a/example/lib/discovery.dart b/example/lib/discovery.dart
@@ -27,7 +27,8 @@ class _MyAppState extends State<MyApp> {
               mainAxisAlignment: MainAxisAlignment.center,
               children: [
                 const Text('You have clicked the button this many times:'),
-                Text('$count', style: Theme.of(context).textTheme.headline4),
+                // Text('$count', style: Theme.of(context).textTheme.headline4),
+                Text('$count'),
                 ElevatedButton(
                   onPressed: () => setState(() => showDiscovery = true),
                   child: const Text('Show discovery'),
@@ -103,19 +104,18 @@ class Discovery extends StatelessWidget {
               top: 100,
               left: 50,
               width: 200,
-              child: DefaultTextStyle(
-                style: Theme.of(context).textTheme.headline5!,
-                child: TweenAnimationBuilder<double>(
-                  duration: kThemeAnimationDuration,
-                  curve: Curves.easeOut,
-                  tween: Tween(begin: 0, end: visible ? 1 : 0),
-                  builder: (context, opacity, _) {
-                    return Opacity(
-                      opacity: opacity,
-                      child: description,
-                    );
-                  },
-                ),
+              // child: DefaultTextStyle(
+              // style: Theme.of(context).textTheme.headline5!,
+              child: TweenAnimationBuilder<double>(
+                duration: kThemeAnimationDuration,
+                curve: Curves.easeOut,
+                tween: Tween(begin: 0, end: visible ? 1 : 0),
+                builder: (context, opacity, _) {
+                  return Opacity(
+                    opacity: opacity,
+                    child: description,
+                  );
+                },
               ),
             )
           ],