Skip to content

Commit

Permalink
Merge pull request #97 from srawlins/patch-1
Browse files Browse the repository at this point in the history
Use strict analysis modes instead of deprecated 'strong-mode' options
  • Loading branch information
fzyzcjy authored Dec 16, 2022
2 parents e55bef8 + e5b8162 commit 424d016
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ analyzer:
exclude:
- "**/*.g.dart"
- "**/*.freezed.dart"
strong-mode:
implicit-casts: false
implicit-dynamic: false
language:
strict-casts: true
strict-raw-types: true
errors:
# Otherwise cause the import of all_lint_rules to warn because of some rules conflicts.
# We explicitly enabled even conflicting rules and are fixing the conflict
Expand Down
2 changes: 1 addition & 1 deletion lib/src/portal.dart
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class Portal extends StatefulWidget {
}) : super(key: key);

final String? debugName;
final List<PortalLabel> labels;
final List<PortalLabel<dynamic>> labels;
final Widget child;

@override
Expand Down
2 changes: 1 addition & 1 deletion lib/src/portal_link.dart
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class PortalLinkScope extends InheritedWidget {

final String? debugName;
final PortalLink portalLink;
final List<PortalLabel> portalLabels;
final List<PortalLabel<dynamic>> portalLabels;

@override
bool updateShouldNotify(PortalLinkScope oldWidget) {
Expand Down
2 changes: 1 addition & 1 deletion lib/src/portal_target.dart
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ class PortalTarget extends StatefulWidget {
..add(DiagnosticsProperty<Anchor>('anchor', anchor))
..add(DiagnosticsProperty<Duration>('closeDuration', closeDuration))
..add(DiagnosticsProperty<Widget>('portalFollower', portalFollower))
..add(DiagnosticsProperty<List<PortalLabel>>(
..add(DiagnosticsProperty<List<PortalLabel<dynamic>>>(
'portalCandidateLabels', portalCandidateLabels))
..add(DiagnosticsProperty('debugName', debugName))
..add(DiagnosticsProperty<Widget>('child', child));
Expand Down

0 comments on commit 424d016

Please sign in to comment.