Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

en_US locale provider for jobTitle added. #839

Closed
wants to merge 1 commit into from
Closed

en_US locale provider for jobTitle added. #839

wants to merge 1 commit into from

Conversation

thudfactor
Copy link

Added a method to the en_US/Company provider to give access to the job title array instead instead of a "lorem" word.

@fzaninotto
Copy link
Owner

No, it doesn't make sense to override the parent method in this class and all the others just for phpDoc.

@fzaninotto fzaninotto closed this Feb 29, 2016
@thudfactor
Copy link
Author

I don't understand the criticism; phpDoc had nothing to do with why I was making the pull request.

Using the en_US region, if I call jobTitle() without making this change, all I get is a latinish word. Pull request #630 includes a jobTitle array but it doesn't appear to be accessed by anything; I thought I was following similar code elsewhere.

It's my first pull request to this project so I probably don't sufficiently understand where something like this should go -- can you point me in the right direction?

@fzaninotto
Copy link
Owner

It's because the en_US locale didn't use the right variable name. It's now fixed (see 416a132).

@thudfactor
Copy link
Author

Thanks! I think I see how that's working now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants