This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Improving pt_BR Providers #335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code extensibility was improved by changing private property to protected; Additional methods to generate some Brazilian documents were included
PhoneNumber was rewritten to enable different phone rules in Brazil. Now it generated area codes, landline and cellphone numbers, obeying the rules for the new digit that was added in the last years (and will still be added in the future). The formats are now local-only, like the original PhoneNumber class.
| ```php | ||
| <?php | ||
|
|
||
| // Now the names generators may include double first or double last names, plus title and suffix |
There was a problem hiding this comment.
You can omit the "now".
Also, typo in "names" generator.
|
No news for more than 6 months, closing. |
|
I was never notified of those comments! I only discovered about this when a friend was looking for those improvements and couldn't find. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, I've added samples to the repository README :)