Add firstname gender method to all Person provider #114

csanquer · 2013-02-19T10:57:23Z

Hi,

This is a missing feature already implemented in some localized Person provider but useful to all Person Providers.

The refactoring is not completed and I need some help to separate male and female firstname.

Concerned files have this comment :

// TODO separate male and female firstname

Remaining localized Person classes which need male and female firstname separating :

Some firstnames remain unknown

Dynom · 2013-05-18T15:33:20Z

I've made some changes to the nl_NL provider. While it doesn't yet reflect your changes, it does add separation to Famale/Male first names. #135

csanquer · 2013-05-20T12:20:04Z

Thanks dynom, i added your firstnames list into nl_NL Person.

oliveiraev · 2013-05-20T18:55:02Z

When the PR is accepted, I'll take care of pt_BR.

Dynom · 2013-05-20T18:56:41Z

Awesome @csanquer, thanks!

EmmanuelVella · 2013-10-22T21:27:56Z

Any news on this PR ?

csanquer · 2014-03-11T07:52:15Z

I' m working on it again, and i'll update this PR with recent Master changes

nineinchnick · 2014-03-11T08:00:11Z

I just made a PR #276 for pl_PL yesterday.

nineinchnick · 2014-03-11T10:46:10Z

src/Faker/Provider/pl_PL/Person.php

+    );
+
+    // TODO separate male and female title
+    protected static $titleMale = array('mgr','inż.', 'dr', 'doc.');


Those are academic degrees and they're unisex. Mr and Ms equivalents are:

Pan for male

Pani for female

I don't think they should be included in default patterns, why some names should have the Mr/Ms prefix and others don't? For academic degrees you either have some or any at all.

Thanks for your explanation, I will update that.

fzaninotto · 2014-03-13T18:36:06Z

I ran php-cs-fixer and it seems this PR needs rebase...

csanquer · 2014-03-14T09:22:13Z

ok I forgot to use php-cs-fixer but the PR is not yet ready, there are still 14 remaining locale provider to update and split firstnames

nineinchnick · 2014-03-14T09:45:48Z

Maybe this could be split into more PRs? Seems like an awful lot of work and it already waits for quite long time.

csanquer · 2014-03-14T11:24:32Z

I rebased and updated more i18n providers but I still need help for the remaining locales.

I used REST API like genderize.io or gender-api.com but even with these usefull web services, some firstname genders remain unknown.

csanquer · 2014-03-19T16:57:11Z

I updated all person providers and splitted all firstnames, titles and name formats into male and female.

Some providers have commented unknown gender firstnames (en_ZA, lv_LV, sr_*, zh_CN).
These person providers could be updated later but they are usable now with limited male and female firstnames lists.

I rebased and squashed the PR. It's ready for merge.

fzaninotto · 2014-03-20T16:18:54Z

readme.md

+    titleMale                 // 'Mr.'
+    titleFemale               // 'Ms.'
+    suffix                    // 'Jr.'
+    name($gender = null)      // 'Dr. Zane Stroman' // false, 0, 'male', 'm', 'boy' ,'b', 'man' for male; true, 1, 'female', 'f', 'girl', 'g', 'w', 'woman' for female; null or other value for any male or female firstname


You should "hide" all the possible choices in the $gender value - they make the doc more complex to read. It's ok to leave all those details in the PHPDoc, but here in the README, you should only show $gender = 'male|female'

fzaninotto · 2014-03-20T16:35:27Z

Please revert work on locales where you have undefined gender - this reduces the randomness of data.

csanquer · 2014-03-20T20:20:18Z

I followed your advices and improved the implementation and restore undefined gender firstnames into male and female firstnames list

miguelgonz · 2014-03-25T23:24:35Z

Thanks @csanquer hopefully this gets merged soon.

fzaninotto · 2014-03-26T17:29:11Z

src/Faker/Provider/Person.php

    }

    /**
     * @example 'Doe'
     */
-    public static function lastName()
+    public function lastName()


why not static anymore?

Because in some I18N Person providers like bg_BG , I need to use $this->generator->parse otherwise some tests failed

and I follow your advice to refactore using more formats

csanquer · 2014-03-27T13:49:51Z

Is there anything that prevents merging this PR ?

ktzar · 2014-04-11T19:49:06Z

👍 There's a lot of people waiting for this PR to get merged. Lot of work in it.

csanquer · 2014-04-12T12:22:50Z

Yes I know, maybe @fzaninotto is very busy these days. He was at the symfony live in Paris this week.

fzaninotto · 2014-04-13T20:45:40Z

Needs rebase

fzaninotto · 2014-04-13T20:47:53Z

src/Faker/Provider/sr_RS/Person.php

    );

-    /**
-     * @link http://sr.wikipedia.org/wiki/%D0%A1%D0%BF%D0%B8%D1%81%D0%B0%D0%BA_%D1%81%D1%80%D0%BF%D1%81%D0%BA%D0%B8%D1%85_%D0%B8%D0%BC%D0%B5%D0%BD%D0%B0


Why did you remove the source? It's necessary.

Oops !! Maybe, a rebase conflict not correctly resolved.

add FirstNameMale and FirstNameFemale method to all Person classes add gender parameter to some localized lastname and prefix method update README add missing prefix method for bg_BG Person provider set male and female firstnames for netherland locales refactore is_IS firstname providers add more values for gender parameter rename person prefix methods to title and refactore them separate male and female en_US firstname update all Person Providers add some unit tests for man, woman firstname and title replace male and female title by academic degrees only for pl_PL add polish names source comment update male and female firstname for fr_FR, fr_CA and fr_BE update male and female firstnames for es_AR, es_ES and es_PE update male and female firstnames for pt_BR update male and female firstnames and titles for it_IT change title behavior for cs_CZ update male and female firstnames for da_DK change title behavior for nl_NL update male and female firstnames for hu_HU fix PSR2 coding style fix PSR2 coding style update male and female bengali titles fix firstnames unit tests for me_ME update male and female firstnames and titles for en_ZA and fi_FI (some names stay with gender unkown) update male and female firstnames for lv_LV update male and female firstnames for tr_TR update male and female firstnames for zh_CN update male and female firstnames for ja_JP update male and female firstnames for fi_FI update male and female firstnames for bn_BD update male and female firstnames for ru_RU fix title method for sk_SK update partially male and female firstnames for sr_* update README remove deprecated comments update male and female firstnames and title for hy_AM update male and female firstnames for uk_UA add gender option to name formatter fix PSR2 coding style make gender option more simple and improve implementation restore unknown gender firstnames into male and female firstnames list update es_ES firstnames list restore source link for sr_RS Person firstname provider simplify Person name unit test

csanquer · 2014-04-14T07:11:35Z

i have fixed the lines you comment and rebase and squash the PR

fzaninotto · 2014-04-14T12:12:40Z

Let's get this rolling

Add firstname gender method to all Person provider

fzaninotto · 2014-04-14T12:13:10Z

Thanks a lot for all your work on this PR, @csanquer! This is much appreciated.

csanquer · 2014-04-14T15:24:04Z

I hope just someone can update the last providers which I can't split firstnames.

csanquer mentioned this pull request Mar 11, 2014

split polish names into male and female #276

Closed

nineinchnick reviewed Mar 11, 2014
View reviewed changes

csanquer mentioned this pull request Mar 11, 2014

Added ME (Montenegrian) localisation #257

Merged

fzaninotto reviewed Mar 20, 2014
View reviewed changes

csanquer mentioned this pull request Mar 25, 2014

es_ES: Add male and female names data and accessors #288

Closed

fzaninotto reviewed Mar 26, 2014
View reviewed changes

fzaninotto reviewed Apr 13, 2014
View reviewed changes

fzaninotto added a commit that referenced this pull request Apr 14, 2014

Merge pull request #114 from csanquer/feature_firstname_gender

7a1cd40

Add firstname gender method to all Person provider

fzaninotto merged commit 7a1cd40 into fzaninotto:master Apr 14, 2014

ulrikjohansson mentioned this pull request May 7, 2014

Add Swedish locale #316

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add firstname gender method to all Person provider #114

Add firstname gender method to all Person provider #114

csanquer commented Feb 19, 2013

Dynom commented May 18, 2013

csanquer commented May 20, 2013

oliveiraev commented May 20, 2013

Dynom commented May 20, 2013

EmmanuelVella commented Oct 22, 2013

csanquer commented Mar 11, 2014

nineinchnick commented Mar 11, 2014

nineinchnick Mar 11, 2014

csanquer Mar 11, 2014

fzaninotto commented Mar 13, 2014

csanquer commented Mar 14, 2014

nineinchnick commented Mar 14, 2014

csanquer commented Mar 14, 2014

csanquer commented Mar 19, 2014

fzaninotto Mar 20, 2014

fzaninotto commented Mar 20, 2014

csanquer commented Mar 20, 2014

miguelgonz commented Mar 25, 2014

fzaninotto Mar 26, 2014

csanquer Mar 26, 2014

csanquer Mar 26, 2014

csanquer commented Mar 27, 2014

ktzar commented Apr 11, 2014

csanquer commented Apr 12, 2014

fzaninotto commented Apr 13, 2014

fzaninotto Apr 13, 2014

csanquer Apr 14, 2014

csanquer commented Apr 14, 2014

fzaninotto commented Apr 14, 2014

fzaninotto commented Apr 14, 2014

csanquer commented Apr 14, 2014

Add firstname gender method to all Person provider #114

Add firstname gender method to all Person provider #114

Conversation

csanquer commented Feb 19, 2013

Dynom commented May 18, 2013

csanquer commented May 20, 2013

oliveiraev commented May 20, 2013

Dynom commented May 20, 2013

EmmanuelVella commented Oct 22, 2013

csanquer commented Mar 11, 2014

nineinchnick commented Mar 11, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fzaninotto commented Mar 13, 2014

csanquer commented Mar 14, 2014

nineinchnick commented Mar 14, 2014

csanquer commented Mar 14, 2014

csanquer commented Mar 19, 2014

Choose a reason for hiding this comment

fzaninotto commented Mar 20, 2014

csanquer commented Mar 20, 2014

miguelgonz commented Mar 25, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

csanquer commented Mar 27, 2014

ktzar commented Apr 11, 2014

csanquer commented Apr 12, 2014

fzaninotto commented Apr 13, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

csanquer commented Apr 14, 2014

fzaninotto commented Apr 14, 2014

fzaninotto commented Apr 14, 2014

csanquer commented Apr 14, 2014