Turn on linter (clippy)

.travis.yml

@@ -2,5 +2,5 @@ language: rust
 rust:
     - nightly
 script:
-    - cargo build
+    - cargo build # Linter is also executed here
     - RUST_BACKTRACE=1 cargo test

Cargo.toml

@@ -2,6 +2,7 @@
 name = "foxbox"
 version = "0.1.0"
 authors = ["fabrice <fabrice@desre.org>"]
+build = "build.rs"
 
 [dependencies]
 getopts = "0.2.14"
@@ -15,3 +16,4 @@ serde = "0.6.11"
 serde_json = "0.6.0"
 serde_macros = "0.6.11"
 uuid = "0.1.18"
+clippy = "0.0.37"

build.rs

@@ -0,0 +1,15 @@
+use std::env;
+use std::fs;
+use std::path::Path;
+
+fn update_local_git_hook() {
+    let p = env::current_dir().unwrap();
+    let origin_path = Path::new(&p).join("./tools/pre-commit");
+    let dest_path = Path::new(&p).join(".git/hooks/pre-commit");
+
+    fs::copy(&origin_path, &dest_path).unwrap();
+}
+
+fn main() {
+    update_local_git_hook();
+}

src/context.rs

@@ -88,16 +88,16 @@ fn test_should_add_a_service() {
         fn get_properties(&self) -> ServiceProperties {
             ServiceProperties {
                 id: '1'.to_string(),
-                name: "dummy service".to_string(),
-                description: "really nothing to see".to_string(),
+                name: "dummy service".to_owned(),
+                description: "really nothing to see".to_owned(),
                 http_url: '2'.to_string(),
                 ws_url: '3'.to_string()
             }
         }
         fn start(&self)  {}
         fn stop(&self) {}
         fn process_request(&self, req: &Request) -> IronResult<Response> {
-            return Ok(Response::new());
+            Ok(Response::new())
         }
     }
 

src/main.rs

@@ -9,6 +9,10 @@
 // Needed for IntoIter in context.rs
 #![feature(collections)]
 
+// Make linter fail for every warning
+#![plugin(clippy)]
+#![deny(clippy)]
+
 extern crate core;
 extern crate getopts;
 #[macro_use]

tools/pre-commit

@@ -0,0 +1,28 @@
+#!/bin/bash
+
+CARGO_EXECUTABLE="cargo"
+CARGO_COMMAND="build"
+
+hash cargo > /dev/null 2>&1
+if [ $? -eq 1 ];
+then
+  echo >&2 "You should install cargo to lint your patch"
+  echo >&2 "https://crates.io/install"
+  exit 0
+fi
+
+rs_changed_files=`git diff --staged --name-only --diff-filter=ACMRT | grep '\.rs$'`
+if [ -n "$rs_changed_files" ]
+then
+
+  echo "clippy check:"
+
+  $CARGO_EXECUTABLE $CARGO_COMMAND
+  cargot_result=$?
+
+  if [ $cargot_result -ne 0 ] ; then
+    echo "There were errors while linting the files, please see above."
+    exit 1
+  fi
+
+fi