Managing errors

[julienw]

For reference, here is the current code: https://github.com/fxbox/foxbox/blob/998b6e0e1e1fd3cba3b711783eaa7000c2f66a0d/src/adapters/mod.rs#L61-L69

Basically we unwrap on any error. Some adapters are not returning an Error for some errors because of this.

The end-user can't see panics because his only access is through a web browser. So we need another way to log the error instead and let the user act on it (especially we might need to be able to restart the foxbox from the browser -- but this is for another issue, I think).

First tentative solution:

• init methods return a taxonomied error enum.
• this error would show error levels: eg: Warn, Fatal, Critical.
• this error would contain the cause. The cause should be a real error that implements Display/Debug/Error.
• the box would log the result somewhere the user can look at (but this can be in a separate RFC). For now we could simply log warnings and panic at fatal and critical errors.

Second tentative solution:

• we replace env_logger with a logger that would keep the logs in a central place to display it through a we bbrowser
• the adapters init function directly uses this to log what needs to be logged
• the adapters init function returns a Error only for Critical errors.

[Yoric]

I fully agree that the problem exists.

Any chance you could turn this RFC into one (or more) Pull Requests (with examples) so that we can comment line-by-line?

[julienw]

Yes, but I just couldn't yet. I merely braindumped.

[julienw]

After discussing with @JohanLorenzo I think we can rename this to "Manage errors" because this is broader than just the adapters start.

[julienw]

Created PR #16