Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Oracle Linux support #386

Merged
merged 4 commits into from
Mar 16, 2017
Merged

Add Oracle Linux support #386

merged 4 commits into from
Mar 16, 2017

Conversation

Djelibeybi
Copy link
Contributor

Signed-off-by: Avi Miller avi.miller@oracle.com

What did you implement:

Closes #385

How did you implement it:

Modified the existing scan/redhat.go and scan/redhat_test.go source to identify Oracle Linux. Also updated report/util.go and report/writer.go to reference the correct URL for the Oracle Linux CVE and Errata information.

How can we verify it:

Scan an Oracle Linux Docker image. You can scan oraclelinux:5, oraclelinux:6 and oraclelinux:7. The last image/tag is also oraclelinux:latest

Todos:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Signed-off-by: Avi Miller <avi.miller@oracle.com>
Signed-off-by: Avi Miller <avi.miller@oracle.com>
Signed-off-by: Avi Miller <avi.miller@oracle.com>
Signed-off-by: Avi Miller <avi.miller@oracle.com>
@Djelibeybi Djelibeybi changed the title Oraclelinux support Add Oracle Linux support Mar 16, 2017
@kotakanbe
Copy link
Member

@Djelibeybi

Many thanks.
LGTM :) Perfect.

I will merge this P/R.
Would you merge in only one commit?
http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

@Djelibeybi
Copy link
Contributor Author

@kotakanbe I can squash them, or you can use GitHub's "Squash and Merge" button, which does it automatically for both of us. :)

@kotakanbe kotakanbe merged commit 986762c into future-architect:master Mar 16, 2017
@kotakanbe
Copy link
Member

kotakanbe commented Mar 16, 2017

To be honest, I just knew it now :)
Thanks!

@kotakanbe kotakanbe added this to the v0.3.0 milestone Mar 16, 2017
@Djelibeybi
Copy link
Contributor Author

Yeah, I get lazy these days because I know GitHub can squash things on merge. :)

lapthorn pushed a commit to lapthorn/vuls that referenced this pull request May 11, 2017
Adding support for Oracle Linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants