Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IAM role for report to S3. #370

Merged
merged 1 commit into from
Mar 7, 2017

Conversation

ohsawa0515
Copy link
Contributor

@ohsawa0515 ohsawa0515 commented Mar 5, 2017

What did you implement:

Closes #250

How did you implement it:

How can we verify it:

Please create the following IAM role and attach it to the EC2 instance, run vuls report.

{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": [
                "s3:ListAllMyBuckets"
            ],
            "Resource": "arn:aws:s3:::*"
        },
        {
            "Effect": "Allow",
            "Action": [
                "s3:PutObject"
            ],
            "Resource": "arn:aws:s3:::vuls/*"
        }
    ]
}
$ vuls report \
    -format-json \
    -to-s3 \
    -aws-region=ap-northeast-1 \
    -aws-s3-bucket=vuls

Todos:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@kotakanbe kotakanbe merged commit e1de8ab into future-architect:master Mar 7, 2017
@kotakanbe
Copy link
Member

Many Thanks!

@kotakanbe kotakanbe added this to the v0.3.0 milestone Mar 7, 2017
@kotakanbe kotakanbe mentioned this pull request Mar 7, 2017
@ohsawa0515 ohsawa0515 deleted the support_iam_role branch March 7, 2017 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants