Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ssh option from -t to -tt #369

Merged
merged 1 commit into from
Mar 6, 2017

Conversation

knqyf263
Copy link
Contributor

@knqyf263 knqyf263 commented Mar 3, 2017

What did you implement:

Closes #359

How did you implement it:

Change ssh option from -t to -tt.
If ssh has no local tty, -tt option should be used to force pseudo-terminal allocation.

$ man ssh
 -t      Force pseudo-terminal allocation.  This can be used to execute arbitrary screen-based programs on a remote machine, which can be very useful, e.g. when implementing menu services.Multiple -t options force tty allocation, even if ssh has no local tty.

How can we verify it:

$ ./vuls scan -ssh-external

Todos:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@kotakanbe kotakanbe merged commit 2f3eddd into future-architect:master Mar 6, 2017
@kotakanbe
Copy link
Member

Many Thanks!

@knqyf263 knqyf263 deleted the change_option branch March 6, 2017 06:00
@kotakanbe kotakanbe added the bug label Mar 6, 2017
@kotakanbe kotakanbe added this to the v0.3.0 milestone Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants