Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep output of "vuls scan -report-*" to be same every times #272

Merged

Conversation

yoheimuta
Copy link
Contributor

@yoheimuta yoheimuta commented Nov 21, 2016

An output of "vuls scan -report-*" may be different with each other, even though the target servers are not changed at all.

Because the CvePacksInfo.Packs are generated in parallel by goroutines, the order is indeterminate.

This behavior makes difficult to implement a custom feature to notify the difference from the previous scan result.

[MEMO] The pull request might also be helpful for #255.

@kotakanbe kotakanbe merged commit 8db147a into future-architect:master Nov 29, 2016
@kotakanbe
Copy link
Member

kotakanbe commented Nov 29, 2016

Sorry for late reply.
I tested and merged.
Thanks for your contribution 👍

@yoheimuta
Copy link
Contributor Author

Thanks!

@yoheimuta yoheimuta deleted the sort-CveInfo-PackageInfo branch November 29, 2016 03:44
@kotakanbe kotakanbe added the bug label Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants