Update dependencies and tests for testing middleware fix #100
Conversation
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
=====================================
+ Coverage 78% 86% +8%
=====================================
Files 2 2
Lines 50 50
Branches 16 16
=====================================
+ Hits 39 43 +4
+ Misses 9 6 -3
+ Partials 2 1 -1
Continue to review full report at Codecov.
|
| @@ -59,7 +59,7 @@ onerror = function(m,s,l,c,e) { | |||
| }; | |||
| </script>`; | |||
| ctx.template.head.unshift(script); | |||
| } else if (ctx.path === ctx.prefix + '/_errors') { | |||
| } else if (ctx.path === '/_errors') { | |||
There was a problem hiding this comment.
Don't we want the prefix?
There was a problem hiding this comment.
I was told that we strip the prefix, but it looks like we might only strip it for the URL, and not path?
https://github.com/fusionjs/fusion-cli/blob/master/lib/strip-prefix.js
There was a problem hiding this comment.
(Path is probably derived from the URL, but will do some verification)
There was a problem hiding this comment.
Cool, almost forget about the stripping
|
!merge |
No description provided.