-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address admin class has name in search_fields #130
Comments
Thanks for the report, @pyarun. This looks like a 10 year old mistake in Here are the valid fields, what were you hoping to search on here? |
I think raw, route, and street_number are good candidates. If you agree, I will see if I can fix and create an MR. |
@pyarun. I agree those are good candidates. If you'd like to create a PR, for this here #130, I'd be happy to review and merge. If you have time to add tests, they're welcome but not absolutely necessary. I'll push this to next release for now. *edit: I left this in 0.2.6 because I pushed it out until next weekend. If you need more time no problem. |
I didn't see any test cases for admin, and I have never written a test for admin, so not sure how to write it. |
Fixes #130, corrects search fields for django admin page
@pyarun, it looks like there are ways to test modeladmin but it is for more sophisticated operations. I tested your fix and it is good. Thank you. |
Address Model does not have a
name
field. But django admin model hasname
insearch_fields
.This causes Error in Admin when we search.
The text was updated successfully, but these errors were encountered: