Investigate / Resolve failing test

[banagale]

Run python example_site/manage.py test example_site/
Creating test database for alias 'default'...
............................F....

System check identified no issues (0 silenced).
FAIL: test_unique_name_state (address.tests.test_models.LocalityTestCase)

Traceback (most recent call last):
File "/home/runner/work/django-address/django-address/example_site/address/tests/test_models.py", line 101, in test_unique_name_state
self.assertRaises(IntegrityError, Locality.objects.create, name='Melbourne', state=self.au_vic)
AssertionError: IntegrityError not raised by create

---

Ran 33 tests in 0.080s

FAILED (failures=1)
Destroying test database for alias 'default'...
##[error]Process completed with exit code 1.

[banagale]

What does this test do?

• Tests to ensure a locality with a given name must have a unique state

        Locality.objects.create(name='Melbourne', state=self.au_qld)
        Locality.objects.create, name='Melbourne', state=self.au_vic)

Led to an integrity error at some point.

Looks like the unique requirement was removed in 2015. :)

Questions from this ticket:

• Maybe there was a unique together on the fk to state previously?
• Look at the history of the Locality model definition
  Answers:

Yes, Locality had a unique together previously and that had been commented out 5 years ago. The test was never updated so it appears the test has been broken since then.

Questions for the future:

• Do we need to audit testing on this project? (probably: Follow-on Audit Test Suite for this package  #126
• Do we need coverage? (wouldn't hurt. Perhaps a ticket to address this should as a follow-on of Audit Test Suite for this package  #126.)

[banagale]

Fixed in 0c83884.