Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING CHANGE] implement interface - use router pattern #33

Merged
merged 4 commits into from
Aug 12, 2022

Conversation

fumito-ito
Copy link
Owner

Previous messageHandlers pattern is easy but confusing which handler will be executed when message is triggered. So this PR change interfaces to router pattern.

router pattern has following benefits.

  • it is clear which handler will be triggered
  • separate responsibilities Is it possible to handle this message ? and How to handle this message ?

@fumito-ito fumito-ito merged commit d0ad312 into master Aug 12, 2022
@fumito-ito fumito-ito deleted the feature/implement-interface branch August 12, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant