Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "asdf:" in front of "defsystem" to compile with no error #28

Closed
wants to merge 1 commit into from

Conversation

vindarel
Copy link

so that we can C-c C-c the defsystem with no error like before.

otherwise we get

The function [first occurence of :depends-on] is undefined

It works back with

(asdf:defsystem ...

or by adding back the lines that were suppressed in commit d5dc886 "use ASDF3 to be modern" one month ago.

This works back for me. Cheers, thanks for the stuff, please make some noise to promote CL21 :) (I try, and feeling alone)

so that we can C-c C-c the defsystem with no error like before.
@vindarel vindarel changed the title add "asdf:" in front of "defsystem", source and skeleton to compile with no error add "asdf:" in front of "defsystem" to compile with no error Nov 30, 2017
@fukamachi
Copy link
Owner

fukamachi commented Sep 27, 2018

Unfortunately, it’s not recommended by ASDF.

System definition files are loaded with the current package bound to the package :asdf-user, that uses the packages :cl, :asdf and :uiop. Therefore, you don't need to and you SHOULD NOT specify cl:, asdf: or uiop: prefixes when referring to symbols in these respective packages. It is considered bad form to do so, unless you changed the package, and even then, your package should probably use these packages, too. In particular you SHOULD NOT to write (asdf:defsystem "foobar" ...) instead of (defsystem "foobar" ...). Also, you SHOULD NOT use (in-package ...) or (defpackage ...) if all you do can legitimately be done in package ASDF-USER.

https://github.com/roswell/asdf/blob/master/doc/best_practices.md#trivial_packaging

@vindarel
Copy link
Author

Ok, thanks !

@fukamachi fukamachi closed this Nov 13, 2018
@vindarel vindarel deleted the asdf-defsystem branch November 13, 2018 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants