Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding is broken #10

Closed
QtRoS opened this issue Nov 15, 2016 · 4 comments
Closed

Encoding is broken #10

QtRoS opened this issue Nov 15, 2016 · 4 comments
Assignees

Comments

@QtRoS
Copy link

QtRoS commented Nov 15, 2016

Result of
QImage QZXing::encodeData(const QString& data)
is incorrect QR Code. Even zxing site can't recognize it.

@ftylitak ftylitak self-assigned this Nov 16, 2016
@ftylitak
Copy link
Owner

ftylitak commented Nov 16, 2016

Hello QtRoS,

the "encodeData" is a work in progress and it has not yet been included to any official release. Its main part is implemented though there is an issue with the ReedSolomon encoding that i have not yet resolved.

Here you can see a plan for the next release.

@QtRoS
Copy link
Author

QtRoS commented Nov 16, 2016

Thank you for the answer!
What's wrong with that part? Can I help you?

@ftylitak
Copy link
Owner

ftylitak commented Nov 17, 2016

The code part that i am referring to is in file src/zxing/zxing/common/reedsolomon/ReedSolomonEncoder.cpp

I have ended up to this part of code since all the rest functionality used in src/zxing/zxing/qrcode/encoder/QREncoder.cpp has already been successfully covered through the tests in src/QZXingTests.

All the above code is direct port from the java code of zxing v2.3 source code. Thus if you are interested in investigating, you can use that code as a reference as well.

Your help and your input are very welcomed!

@fenixrus
Copy link

Will the solution of this issue?

ftylitak added a commit that referenced this issue Apr 18, 2017
…ssfull but still the images produced can not be decoded. One step closer to #10
ftylitak added a commit that referenced this issue Apr 19, 2017
ftylitak added a commit that referenced this issue Apr 19, 2017
Still the Qr code that is generated is not recognizable
ftylitak added a commit that referenced this issue Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants