Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove scalac dependency #592

Closed
wants to merge 1 commit into from

Conversation

yanns
Copy link

@yanns yanns commented Nov 29, 2018

I'm not sure if we need the scalac dependency in core.

@fthomas
Copy link
Owner

fthomas commented Dec 10, 2018

The 2.12 build failed with

[error] /home/travis/build/fthomas/refined/modules/core/jvm/target/scala-2.12/src_managed/test/eu/timepit/refined/autoDoctest.scala:22:43: Class scala.tools.nsc.typechecker.Contexts not found - continuing with a stub.
[error]     val x: Int Refined Greater[W.`5`.T] = 100
[error]                                           ^

We've seen this error before in #256 which was also caused by removing the scala-compiler dependency in version 0.7.0. We brought it back in 0.8.0.

The dependency is needed for refined's macros. If we want to remove that dependency, we have to move the macros into a new refined-macros module. Moving macros into its own module would make it easier to cross-compile refined with dotty, so I'd be in favour of such split.

@fthomas
Copy link
Owner

fthomas commented Jun 16, 2019

I've opened an issue for moving the macros to a new module and hence closing this PR.

@fthomas fthomas closed this Jun 16, 2019
@yanns yanns deleted the remove_scalac_dependency branch June 16, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants