Move compiler-dependent code into a module #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2f5262c to
964eaef
Compare
Current coverage is 99.26% (diff: 100%)@@ master #251 diff @@
==========================================
Files 35 36 +1
Lines 409 409
Methods 387 388 +1
Messages 0 0
Branches 20 19 -1
==========================================
Hits 406 406
Misses 3 3
Partials 0 0
|
|
This looks great, @clhodapp. Thanks for taking care of this issue! |
|
Thanks for merging! A release including this would be highly appreciated sooner rather than later, as I'm finding that I get classloading failures under Scala 2.12 with Typelevel Scala (that would be fixed by a release of this change). |
|
Also 🤞 that I didn't break the release process. I think it should work. |
|
I'll try to release 0.7.0 today or tomorrow. One thing I'd like to do before is to mark the dependency on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #207
I rejiggered the parts of the build related to binary dependency checking a bit and bumped the version to 0.7.0 (-SNAPSHOT), since the change is breaking.