Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureBlobFileSystem: remove socket_timeout #338

Merged
merged 2 commits into from
Oct 1, 2022
Merged

AzureBlobFileSystem: remove socket_timeout #338

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dfc102
remove unused socket_timeout
dtrifiro Aug 29, 2022
8981976
Update adlfs/spec.py
TomAugspurger Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions adlfs/spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@
]
_ROOT_PATH = "/"

_SOCKET_TIMEOUT_DEFAULT = object()


class AzureDatalakeFileSystem(AbstractFileSystem):
"""
Expand Down Expand Up @@ -350,10 +352,6 @@ class AzureBlobFileSystem(AsyncFileSystem):
request session. See
http://azure.microsoft.com/en-us/documentation/articles/storage-configure-connection-string/
for the connection string format.
socket_timeout: int
If specified, this will override the default socket timeout. The timeout specified is in
seconds.
See DEFAULT_SOCKET_TIMEOUT in _constants.py for the default value.
credential: TokenCredential or SAS token
The credentials with which to authenticate. Optional if the account URL already has a SAS token.
Can include an instance of TokenCredential class from azure.identity
Expand Down Expand Up @@ -424,7 +422,7 @@ def __init__(
credential: str = None,
sas_token: str = None,
request_session=None,
socket_timeout: int = None,
socket_timeout=_SOCKET_TIMEOUT_DEFAULT,
blocksize: int = create_configuration(storage_sdk="blob").max_block_size,
client_id: str = None,
client_secret: str = None,
Expand Down Expand Up @@ -460,7 +458,10 @@ def __init__(
self.location_mode = location_mode
self.credential = credential
self.request_session = request_session
self.socket_timeout = socket_timeout
if socket_timeout is not _SOCKET_TIMEOUT_DEFAULT:
warnings.warn(
"socket_timeout is deprecated and has no effect.", DeprecationWarning
TomAugspurger marked this conversation as resolved.
Show resolved Hide resolved
)
self.blocksize = blocksize
self.default_fill_cache = default_fill_cache
self.default_cache_type = default_cache_type
Expand Down