Simplify works with auto-detected target frameworks #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rictions when the framework is being auto-detected
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1737 by changing the logic of DependenciesFile.SimplifyFrameworkRestrictions so that it no longer called a helper method that threw and exception when the framework is auto-detected. Instead, we use the ProjectFile type and members of the ProjectFile module to get the list of distinct targetframeworkversions, similar to what is already done in other pathways.
To make it work I had to split up DependenciesFile into several smaller files, so that the ordering was such that the actual implementation of DependenciesFile came after ProjectFile.
I included a passing integration test to show the new functionality works.