Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet Plossum.CommandLine creates lib file with %20 in file name #411

Closed
agross opened this issue Dec 1, 2014 · 14 comments
Closed

NuGet Plossum.CommandLine creates lib file with %20 in file name #411

agross opened this issue Dec 1, 2014 · 14 comments

Comments

@agross
Copy link
Contributor

agross commented Dec 1, 2014

The lib/net40/Plossum CommandLine.dll file contains a space that Paket converts to lib/net40/Plossum%20CommandLine.dll inside packages. The reference written by Paket looks like this:

<Reference Include="Plossum%20CommandLine">
    <HintPath>..\..\packages\Plossum.CommandLine\lib\net35\Plossum%2520CommandLine.dll</HintPath>
    <Private>True</Private>
    <Paket>True</Paket>
</Reference>

MSBuild fails to load the assembly when compiling.

@agross agross changed the title NuGet Plossum.CommandLine creates lib file with %20 NuGet Plossum.CommandLine creates lib file with %20 in file name Dec 1, 2014
@theimowski
Copy link
Member

the bug is here. I'll apply a fix

@theimowski
Copy link
Member

Hm, it looks like the lib in package has already %20 in its name. Can you confirm?
image

Edit: It Looks like NuGet is decoding the file name when extracting from the nupkg

@agross
Copy link
Contributor Author

agross commented Dec 1, 2014

Perhaps, I haven't checked the nupkg. A nuget install Plossum.CommandLine unescaped the %20 to .

@agross
Copy link
Contributor Author

agross commented Dec 1, 2014

👍 Didn't see your edit.

@Vidarls
Copy link
Contributor

Vidarls commented Dec 2, 2014

May or may not be the same:

Downloading Newtonsoft.Json 6.0.5 to C:\Users\Vidar\AppData\Local\NuGet\Cache\Newtonsoft.Json.6.0.5.nupkg
Downloading Microsoft.Net.Http 2.2.28 to C:\Users\Vidar\AppData\Local\NuGet\Cache\Microsoft.Net.Http.2.2.28.nupkg
Downloading Microsoft.Bcl 1.1.9 to C:\Users\Vidar\AppData\Local\NuGet\Cache\Microsoft.Bcl.1.1.9.nupkg
Downloading FSharp.Core.Microsoft.Signed 3.1.1.1 to C:\Users\Vidar\AppData\Local\NuGet\Cache\FSharp.Core.Microsoft.Signed.3.1.1.1.nupkg
Downloading Octokit 0.5.2 to C:\Users\Vidar\AppData\Local\NuGet\Cache\Octokit.0.5.2.nupkg
Paket failed with:
   Error during unzipping lib/portable-net40%2Bsl4%2Bwin8%2Bwp71%2Bwpa81/System.Net.Http.dll in Microsoft.Net.Http 2.2.28: Finner ikke en del av banen.

Running Paket 0.17.5

@Vidarls
Copy link
Contributor

Vidarls commented Dec 2, 2014

confirming that downgrading to 0.17.3 removes my above issue

@forki
Copy link
Member

forki commented Dec 2, 2014

Oups. @theimowski should I revert?
On Dec 2, 2014 1:08 PM, "Vidar Løvbrekke Sømme" notifications@github.com
wrote:

confirming that downgrading to 0.17.3 removes my above issue


Reply to this email directly or view it on GitHub
#411 (comment).

@theimowski
Copy link
Member

Yes please do, I'll have some time to look at it later in the evening

@devboy
Copy link
Contributor

devboy commented Dec 2, 2014

I am having the same issue on Mono.

Paket failed with:
   Error during unzipping lib/portable-net45%2Bwp80%2Bwin%2Bwpa81/Octokit.dll in Octokit 0.5.2: Could not find a part of the path.
StackTrace:
    at Paket.NuGetV2+ExtractPackage@297-9.Invoke (System.String message) [0x00000] in <filename unknown>:0
  at Microsoft.FSharp.Core.PrintfImpl+StringPrintfEnv`1[Microsoft.FSharp.Core.Unit].Finalize () [0x00000] in <filename unknown>:0
  at Microsoft.FSharp.Core.PrintfImpl+Final4@268[Microsoft.FSharp.Core.Unit,System.String,Microsoft.FSharp.Core.Unit,System.String,System.String,Paket.SemVerInfo,System.String].Invoke (Microsoft.FSharp.Core.FSharpFunc`2 env, System.String a, System.String b, Paket.SemVerInfo c, System.String d) [0x00000] in <filename unknown>:0
  at Microsoft.FSharp.Core.OptimizedClosures+Invoke@3090-3[System.String,System.String,Paket.SemVerInfo,System.String,Microsoft.FSharp.Core.Unit,Microsoft.FSharp.Core.FSharpFunc`2[Microsoft.FSharp.Core.Unit,Microsoft.FSharp.Core.PrintfImpl+PrintfEnv`3[Microsoft.FSharp.Core.Unit,System.String,Microsoft.FSharp.Core.Unit]]].Invoke (System.String u, System.String v, Paket.SemVerInfo w, System.String x) [0x00000] in <filename unknown>:0
  at Microsoft.FSharp.Core.OptimizedClosures+Invoke@3084-2[System.String,Paket.SemVerInfo,System.String,Microsoft.FSharp.Core.Unit,System.String].Invoke (System.String u, Paket.SemVerInfo v, System.String w) [0x00000] in <filename unknown>:0
  at Microsoft.FSharp.Core.OptimizedClosures+Invoke@3049-1[Paket.SemVerInfo,System.String,Microsoft.FSharp.Core.Unit,System.String].Invoke (Paket.SemVerInfo u, System.String v) [0x00000] in <filename unknown>:0
  at Microsoft.FSharp.Core.OptimizedClosures+Invoke@3036[System.String,Microsoft.FSharp.Core.Unit,Paket.SemVerInfo].Invoke (System.String u) [0x00000] in <filename unknown>:0
  at Paket.NuGetV2+ExtractPackage@297-13.Invoke (System.String arg40) [0x00000] in <filename unknown>:0
  at Microsoft.FSharp.Core.FSharpFunc`2[Paket.SemVerInfo,System.String].InvokeFast[Unit] (Microsoft.FSharp.Core.FSharpFunc`2 func, Paket.SemVerInfo arg1, System.String arg2) [0x00000] in <filename unknown>:0
  at Microsoft.FSharp.Core.FSharpFunc`2[System.String,Paket.SemVerInfo].InvokeFast[String,Unit] (Microsoft.FSharp.Core.FSharpFunc`2 func, System.String arg1, Paket.SemVerInfo arg2, System.String arg3) [0x00000] in <filename unknown>:0
  at Microsoft.FSharp.Core.FSharpFunc`2[System.String,System.String].InvokeFast[SemVerInfo,String,Unit] (Microsoft.FSharp.Core.FSharpFunc`2 func, System.String arg1, System.String arg2, Paket.SemVerInfo arg3, System.String arg4) [0x00000] in <filename unknown>:0
  at Paket.NuGetV2+ExtractPackage@290-8.Invoke (System.Exception _arg3) [0x00000] in <filename unknown>:0
  at Microsoft.FSharp.Control.AsyncBuilderImpl+callA@813[Microsoft.FSharp.Core.Unit,System.Exception].Invoke (Microsoft.FSharp.Control.AsyncParams`1 args) [0x00000] in <filename unknown>:0

forki added a commit that referenced this issue Dec 2, 2014
@forki
Copy link
Member

forki commented Dec 2, 2014

Can you please check the latest version? I reverted the changes.

@devboy
Copy link
Contributor

devboy commented Dec 2, 2014

@forki
Copy link
Member

forki commented Dec 2, 2014

Thanks.

@forki
Copy link
Member

forki commented Dec 3, 2014

I tried to fix it: dd210a1#diff-4d7cd68c6813f092c784e32c518577e6R53

@forki
Copy link
Member

forki commented Dec 3, 2014

so I hope latest Paket works for everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants