We don't have to query all versions when only need specific - referen…

…ces #330
fsprojects · Nov 7, 2014 · 7485bd3 · 7485bd3
1 parent d5cd482
commit 7485bd3
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/src/Paket.Core/PackageResolver.fs b/src/Paket.Core/PackageResolver.fs
@@ -92,11 +92,16 @@ let Resolve(getVersionsF, getPackageDetailsF, rootDependencies:PackageRequiremen
             exploredPackages.Add((packageName.ToLower(),version),explored)
             explored
 
-    let getAllVersions(sources,packageName:string) =
+    let getAllVersions(sources,packageName:string,vr : VersionRange)  =
         match allVersions.TryGetValue(packageName.ToLower()) with
-        | false,_ ->
-            tracefn "  - fetching versions for %s" packageName
-            let versions = getVersionsF(sources,packageName)
+        | false,_ ->            
+            let versions = 
+                match vr with
+                | OverrideAll v -> [v]
+                | Specific v -> [v]
+                | _ -> 
+                    tracefn "  - fetching versions for %s" packageName
+                    getVersionsF(sources,packageName)
             allVersions.Add(packageName.ToLower(),versions)
             versions
         | true,versions -> versions
@@ -131,13 +136,7 @@ let Resolve(getVersionsF, getPackageDetailsF, rootDependencies:PackageRequiremen
             let allVersions,compatibleVersions,globalOverride = 
                 match Map.tryFind dependency.Name filteredVersions with
                 | None ->
-                    let versions = 
-                        match dependency.VersionRequirement.Range with
-                        | Specific v -> 
-                            let versions = [v]
-                            allVersions.Add(dependency.Name.ToLower(),versions)
-                            versions
-                        | _ -> getAllVersions(dependency.Sources,dependency.Name)
+                    let versions = getAllVersions(dependency.Sources,dependency.Name,dependency.VersionRequirement.Range)
                     if Seq.isEmpty versions then
                         failwithf "Couldn't retrieve versions for %s." dependency.Name
                     if dependency.VersionRequirement.Range.IsGlobalOverride then