Fix sprintf format in TemplateTests::getDebuggingInfo #2846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looking at the remaining test failures when running on .NET 8 I noticed that some of the test error messages contained ...Debugging Info: Fake.DotNet.Cli.IntegrationTests.TemplateTests+getDebuggingInfo@58-2 Result: ... and I think that '+getDebuggingInfo' is because the sprintf in getDebuggingInfo contains 3 %s but only two parameters, so it's actually being treated as a partially applied function by the string interpolcation in isProcessSucceeded rather than a string? Looks like it's been like that for some time - not sure what the original intent was
|
Example of the existing test output when an error occurs: https://github.com/fsprojects/FAKE/actions/runs/11109335183/job/30864439817?pr=2818#step:9:8381 |
xperiandri
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at the remaining test failures when running on .NET 8 I noticed that some of the test error messages contained
...Debugging Info: Fake.DotNet.Cli.IntegrationTests.TemplateTests+getDebuggingInfo@58-2 Result: ...
and I think that '+getDebuggingInfo' is because the sprintf in getDebuggingInfo contains 3 %s but only two parameters, so it's actually being treated as a partially applied function by the string interpolcation in isProcessSucceeded rather than a string?
Looks like it's been like that for some time - not sure what the original intent was