Remove the System.Runtime.Loader NuGet reference from Fake.Runtime
#2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a41bb5 to
1c11e8e
Compare
1c11e8e to
a8c0d14
Compare
|
If it builds and tests pass I suppose it is a good modification |
a8c0d14 to
4c45fdf
Compare
xperiandri
approved these changes
Aug 31, 2024
System.Runtime.Loader NuGet reference from Fake.Runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When looking at the dependencies of the Fake.Runtime NuGet package on NuGet.org, I noticed that the Fake.Runtime package depends on System.Runtime.Loader:
And given that Fake.Runtime is only built as .NET 6.0, I wondered if it needs to use the NuGet package, or if it can use the in-box version instead?
Any thoughts?