-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release-docs TOKEN_GITHUB to GITHUB_TOKEN #2802
Conversation
Co-authored-by: Andrii Chebukin <XperiAndri@Outlook.com>
Integration test failed but I expect it's nothing to do with this commit, they are just bit un-reliable, addressed at #2797 . |
|
Ok so it gets further than before, that's good news! The messages you pasted are just informational messages. It is doing token auth, not password auth.
So CI is using that user to try to push the release-docs, but the token is for some other user? |
At a risk of not having a clue what I'm doing (never used gh-pages) - an observation - The build script at Line 997 in f07f74d
x-oauth-basic when building the URL, but looking at the code for some github pages publishing actions, e.g. https://github.com/peaceiris/actions-gh-pages/blob/0b7567fde6f7517edcc13d8ffa2d89cd8734d47c/src/set-tokens.ts#L100, I see them using x-access-token instead.Is that something that needs reviewing? |
…ub pages (#2807) refs #2802 (comment) I don't have a means of testing this, it's just a guess based on some of the Github actions for pushing pages, e.g. https://github.com/peaceiris/actions-gh-pages/blob/0b7567fde6f7517edcc13d8ffa2d89cd8734d47c/src/set-tokens.ts#L100 https://github.com/EdricChan03/action-build-deploy-ghpages/blob/3183472d918d9ea82237bf4f2c416e5c8c13a394/entrypoint.sh#L32
Fix release yaml docs token