Send "do nothing" flag - if we tried to unban not banned user #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szer
reviewed
May 16, 2022
| @@ -32,7 +32,8 @@ let callApiWithDefaultRetry config = callApiWithRetry config 5 | |||
| module ApiExt = | |||
| type UnbanChatMemberReq = | |||
| { ChatId: ChatId | |||
| UserId: int64 } | |||
| UserId: int64 | |||
| OnlyIfBanned: Boolean } | |||
There was a problem hiding this comment.
а нам это точно надо в апи, если мы один хер всегда true посылаем?
Szer
reviewed
May 16, 2022
| @@ -54,8 +55,8 @@ module ApiExt = | |||
| interface IRequestBase<bool> with | |||
| member __.MethodName = "restrictChatMember" | |||
|
|
|||
| let unbanChatMemberByChatNameExt chatName userId : UnbanChatMemberReq = | |||
| { ChatId = ChatId.String chatName; UserId = userId } | |||
| let unbanChatMemberByChatNameExt chatName userId onlyIfBanned : UnbanChatMemberReq = | |||
There was a problem hiding this comment.
я вот не понял нихуя что это за флаг вообще и какое его предназначение!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telegram bot API - unbanChatMember
Without this flag, on misused unban command - user will be removed from chat even if he doesn't was banned from chat