-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict PR deployments to main repo branches only #1378
Conversation
[gi-frontend] [Wed Dec 20 17:15:06 UTC 2023] - Building version [sr-frontend] [Wed Dec 20 17:15:08 UTC 2023] - Building version [gi-frontend] [Wed Dec 20 17:15:09 UTC 2023] - Building version [frontend] [Wed Dec 20 17:15:32 UTC 2023] - Building version [frontend] [Wed Dec 20 17:15:36 UTC 2023] - Building version [sr-frontend] [Wed Dec 20 17:16:04 UTC 2023] - Building version [sr-frontend] [Wed Dec 20 17:16:18 UTC 2023] - Deployed 1e3ece2 to https://genshin-optimizer-prs.github.io/pr/1378/sr-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Wed Dec 20 17:17:35 UTC 2023] - Deployed 63b3bee to https://genshin-optimizer-prs.github.io/pr/1378/sr-frontend (Takes 3-5 minutes after this completes to be available) [gi-frontend] [Wed Dec 20 17:17:39 UTC 2023] - Deployed 1e3ece2 to https://genshin-optimizer-prs.github.io/pr/1378/gi-frontend (Takes 3-5 minutes after this completes to be available) [gi-frontend] [Wed Dec 20 17:17:51 UTC 2023] - Deployed 63b3bee to https://genshin-optimizer-prs.github.io/pr/1378/gi-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Wed Dec 20 17:18:26 UTC 2023] - Deployed 63b3bee to https://genshin-optimizer-prs.github.io/pr/1378/frontend (Takes 3-5 minutes after this completes to be available) [gi-frontend] [Wed Dec 20 17:20:13 UTC 2023] - Building version $(git rev-parse HEAD) [frontend] [Wed Dec 20 17:20:20 UTC 2023] - Building version 63b3bee [sr-frontend] [Wed Dec 20 17:20:25 UTC 2023] - Building version 63b3bee [frontend] [Wed Dec 20 17:20:32 UTC 2023] - Building version $(git rev-parse HEAD) [sr-frontend] [Wed Dec 20 17:20:40 UTC 2023] - Building version $(git rev-parse HEAD) [sr-frontend] [Wed Dec 20 17:21:52 UTC 2023] - Deployed 6ea2e20 to https://genshin-optimizer-prs.github.io/pr/1378/sr-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Wed Dec 20 17:22:05 UTC 2023] - Deployed 63b3bee to https://genshin-optimizer-prs.github.io/pr/1378/sr-frontend (Takes 3-5 minutes after this completes to be available) [gi-frontend] [Wed Dec 20 17:22:43 UTC 2023] - Deployed 6ea2e20 to https://genshin-optimizer-prs.github.io/pr/1378/gi-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Wed Dec 20 17:22:50 UTC 2023] - Deployed 6ea2e20 to https://genshin-optimizer-prs.github.io/pr/1378/frontend (Takes 3-5 minutes after this completes to be available) [gi-frontend] [Wed Dec 20 17:22:56 UTC 2023] - Deployed 63b3bee to https://genshin-optimizer-prs.github.io/pr/1378/gi-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Wed Dec 20 17:23:05 UTC 2023] - Deployed 63b3bee to https://genshin-optimizer-prs.github.io/pr/1378/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Wed Dec 20 17:25:09 UTC 2023] - Building version baf6e84 [gi-frontend] [Wed Dec 20 17:25:14 UTC 2023] - Building version baf6e84 [sr-frontend] [Wed Dec 20 17:25:17 UTC 2023] - Building version 6ea2e20 [frontend] [Wed Dec 20 17:25:43 UTC 2023] - Building version 6ea2e20 [sr-frontend] [Wed Dec 20 17:26:11 UTC 2023] - Deployed 6ea2e20 to https://genshin-optimizer-prs.github.io/pr/1378/sr-frontend (Takes 3-5 minutes after this completes to be available) [sr-frontend] [Wed Dec 20 17:26:30 UTC 2023] - Deployed baf6e84 to https://genshin-optimizer-prs.github.io/pr/1378/sr-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Wed Dec 20 17:27:13 UTC 2023] - Deployed baf6e84 to https://genshin-optimizer-prs.github.io/pr/1378/frontend (Takes 3-5 minutes after this completes to be available) [gi-frontend] [Wed Dec 20 17:27:45 UTC 2023] - Deployed baf6e84 to https://genshin-optimizer-prs.github.io/pr/1378/gi-frontend (Takes 3-5 minutes after this completes to be available) [gi-frontend] [Wed Dec 20 17:27:57 UTC 2023] - Deployed 6ea2e20 to https://genshin-optimizer-prs.github.io/pr/1378/gi-frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Wed Dec 20 17:28:12 UTC 2023] - Deployed 6ea2e20 to https://genshin-optimizer-prs.github.io/pr/1378/frontend (Takes 3-5 minutes after this completes to be available) [Wed Dec 20 17:58:51 UTC 2023] - Deleted deployment |
Describe your changes
Testing/validation
This PR is getting both the old method of deployment (red) and the new method I just added (pink). This highlights the bug we are fixing.
The old method (red) is deploying an old merge commit because it is not waiting for the newest merge commit to be ready. The new method (pink) is waiting and deploying the correct merge commit, so we don't need to trigger a double deployment.
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format + lint.nx format write
to resolve them automatically.