chore: hide detail props from health endpoint

frouriojs · Nov 25, 2024 · d7b5211 · d7b5211
1 parent 50989f3
commit d7b5211
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 18 deletions.
diff --git a/server/api/health/controller.ts b/server/api/health/controller.ts
@@ -12,19 +12,10 @@ const throwCustomError = (label: string) => (e: Error) => {
 export default defineController(() => ({
   get: async () => ({
     status: 200,
-    body: {
-      server: 'ok',
-      db: await prismaClient.$queryRaw`SELECT CURRENT_TIMESTAMP;`
-        .then(() => 'ok' as const)
-        .catch(throwCustomError('DB')),
-      s3: await s3
-        .health()
-        .then(() => 'ok' as const)
-        .catch(throwCustomError('S3')),
-      cognito: await cognito
-        .health()
-        .then(() => 'ok' as const)
-        .catch(throwCustomError('Cognito')),
-    },
+    body: await Promise.all([
+      prismaClient.$queryRaw`SELECT CURRENT_TIMESTAMP;`.catch(throwCustomError('DB')),
+      s3.health().catch(throwCustomError('S3')),
+      cognito.health().catch(throwCustomError('Cognito')),
+    ]).then(() => 'ok'),
   }),
 }));
diff --git a/server/api/health/index.ts b/server/api/health/index.ts
@@ -2,6 +2,6 @@ import type { DefineMethods } from 'aspida';
 
 export type Methods = DefineMethods<{
   get: {
-    resBody: Record<'server' | 'db' | 's3' | 'cognito', 'ok'>;
+    resBody: 'ok';
   };
 }>;
diff --git a/server/tests/api/public.test.ts b/server/tests/api/public.test.ts
@@ -16,9 +16,7 @@ test(GET(noCookieClient.health), async () => {
   const apiClient = await createCognitoUserClient();
   const res = await apiClient.health.$get();
 
-  expect(res.server).toEqual('ok');
-  expect(res.db).toEqual('ok');
-  expect(res.s3).toEqual('ok');
+  expect(res).toEqual('ok');
 });
 
 test(POST(noCookieClient.session), async () => {