Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Added black formatting & refactored configs into pyproject.toml #58

Merged
merged 14 commits into from
May 31, 2022

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented May 31, 2022

This PR introduces the following modifications:

  • fixes the collect_env script
  • moves all configs into pyproject.toml (cf. PEP 518), apart from flake8 that doesn't support it (cf. pyproject.toml (PEP 518) support PyCQA/flake8#234)
  • adds black as code formatter
  • applies black on the codebase
  • made mypy stricter and fixed typing

@frgfm frgfm added type: improvement New feature or request topic: build Related to project build ext: scripts Related to scripts topic: ci topic: style labels May 31, 2022
@frgfm frgfm added this to the 0.2.0 milestone May 31, 2022
@frgfm frgfm self-assigned this May 31, 2022
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #58 (90f82de) into master (0032f78) will decrease coverage by 0.26%.
The diff coverage is 71.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   88.37%   88.10%   -0.27%     
==========================================
  Files          10       10              
  Lines         671      656      -15     
==========================================
- Hits          593      578      -15     
  Misses         78       78              
Impacted Files Coverage Δ
torchscan/modules/receptive.py 64.86% <42.85%> (ø)
torchscan/utils.py 75.00% <53.57%> (ø)
torchscan/crawler.py 82.08% <84.61%> (ø)
torchscan/modules/flops.py 97.48% <100.00%> (-0.10%) ⬇️
torchscan/modules/macs.py 100.00% <100.00%> (ø)
torchscan/modules/memory.py 100.00% <100.00%> (ø)
torchscan/process/memory.py 71.42% <100.00%> (ø)

@frgfm frgfm merged commit 579c189 into master May 31, 2022
@frgfm frgfm deleted the black branch May 31, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: scripts Related to scripts topic: build Related to project build topic: ci topic: style type: improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant