Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improved project code quality #53

Merged
merged 9 commits into from
May 18, 2022
Merged

refactor: Improved project code quality #53

merged 9 commits into from
May 18, 2022

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented May 18, 2022

This PR introduces the following modifications:

  • switched unittest to pytest
  • improved documentation
  • revamped setup
  • added quality checks
  • added contribution guidelines and code of conduct

@frgfm frgfm added type: improvement New feature or request module: utils Related to utils module: crawler Related to crawler module: modules Related to modules module: process Related to process ext: scripts Related to scripts ext: test ext: docs topic: ci labels May 18, 2022
@frgfm frgfm added this to the 0.2.0 milestone May 18, 2022
@frgfm frgfm self-assigned this May 18, 2022
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #53 (cb2e087) into master (358edb6) will decrease coverage by 1.99%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   90.37%   88.37%   -2.00%     
==========================================
  Files          10       10              
  Lines         675      671       -4     
==========================================
- Hits          610      593      -17     
- Misses         65       78      +13     
Impacted Files Coverage Δ
torchscan/process/memory.py 71.42% <0.00%> (ø)
torchscan/crawler.py 82.08% <100.00%> (ø)
torchscan/modules/flops.py 97.57% <100.00%> (-0.02%) ⬇️
torchscan/modules/macs.py 100.00% <100.00%> (ø)
torchscan/modules/memory.py 100.00% <100.00%> (ø)
torchscan/modules/receptive.py 64.86% <100.00%> (-35.14%) ⬇️
torchscan/utils.py 75.00% <100.00%> (ø)

@frgfm frgfm merged commit 4d4fcbf into master May 18, 2022
@frgfm frgfm deleted the revamp branch May 18, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: docs ext: scripts Related to scripts module: crawler Related to crawler module: modules Related to modules module: process Related to process module: utils Related to utils topic: ci type: improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant