Fix power failure report #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The succeeded power in PartialFailure result should exclude any failed power. Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
The test covers the case where the microgrid, for any reason, fails to set power for one of the batteries in the power request. Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
shsms
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The succeeded power in
PartialFailureresult should exclude any failed power.There was no unit tests covering
PartialFailureresults so this patch adds a test to cover the case where the microgrid, for any reason, fails to set power for one of the batteries in the power request.Fixes #751