Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DataSourcingActor to accept current requests for inverters #759

Merged
merged 5 commits into from
Nov 1, 2023
Merged

Update DataSourcingActor to accept current requests for inverters #759

merged 5 commits into from
Nov 1, 2023

Conversation

shsms
Copy link
Contributor

@shsms shsms commented Nov 1, 2023

In some component configurations, it might be necessary to use current
readings from inverters to calculate grid current.

@shsms shsms requested a review from a team as a code owner November 1, 2023 15:59
@shsms shsms requested a review from llucax November 1, 2023 15:59
@github-actions github-actions bot added part:actor Affects an actor ot the actors utilities (decorator, etc.) part:microgrid Affects the interactions with the microgrid part:docs Affects the documentation labels Nov 1, 2023
shsms added 4 commits November 1, 2023 17:07
@shsms
Update inverter component data to extract AC current values
e54f142 
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@shsms
Update DataSourcingActor to accept current requests for inverters
c359d3f 
In some component configurations, it might be necessary to use current
readings from inverters to calculate grid current.

Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@shsms
Add logging for errors that are raised in spun-off tasks
e996547 
Exceptions raised in tasks are available from the `Task` object, but
if no one's looking at the tasks, we don't see anything.  So it is
necessary to log in such cases.

Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@shsms
Update RELEASE_NOTES.md
2f0f836 
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@github-actions github-actions bot added the part:tests Affects the unit, integration and performance (benchmarks) tests label Nov 1, 2023
@shsms shsms added this to the v1.0.0-rc3 milestone Nov 1, 2023
daniel-zullo-frequenz
daniel-zullo-frequenz reviewed Nov 1, 2023
View reviewed changes
Copy link
Contributor

@daniel-zullo-frequenz daniel-zullo-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple of typos, LGTM

@shsms @daniel-zullo-frequenz
Apply suggestions from code review
fa90c12 
Co-authored-by: daniel-zullo-frequenz <120166726+daniel-zullo-frequenz@users.noreply.github.com>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@shsms
Copy link
Contributor Author

shsms commented Nov 1, 2023

Thanks Dani, both done.

@shsms shsms added this pull request to the merge queue Nov 1, 2023
Merged via the queue into frequenz-floss:v1.x.x with commit aad64ed Nov 1, 2023
@shsms shsms deleted the inverter-current branch November 1, 2023 18:19
@shsms shsms mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-zullo-frequenz daniel-zullo-frequenz daniel-zullo-frequenz approved these changes

@llucax llucax Awaiting requested review from llucax llucax is a code owner automatically assigned from frequenz-floss/python-sdk-team

Assignees
No one assigned
Labels
part:actor Affects an actor ot the actors utilities (decorator, etc.) part:docs Affects the documentation part:microgrid Affects the interactions with the microgrid part:tests Affects the unit, integration and performance (benchmarks) tests
Projects
Python SDK Roadmap
Status: Done
Milestone
v1.0.0-rc3
Development

Successfully merging this pull request may close these issues.
2 participants
@shsms @daniel-zullo-frequenz