Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add try/finally to decorated context managers yield statement #757

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Add try/finally to decorated context managers yield statement #757

merged 1 commit into from
Nov 3, 2023

Conversation

christianparpart
Copy link
Contributor

And also log any unhandled caught exception.

Closes #721.

@christianparpart christianparpart requested a review from a team as a code owner November 1, 2023 10:23
@github-actions github-actions bot added part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) labels Nov 1, 2023
llucax
llucax reviewed Nov 1, 2023
View reviewed changes
@christianparpart
Add try/finally to decorated context managers yield statement
8685e9e 
And also log any unhandled caught exception.

Signed-off-by: Christian Parpart <christian@parpart.family>
@christianparpart
Copy link
Contributor Author

christianparpart commented Nov 1, 2023 •
edited
Loading

Updated.

NB: @llucax I did not update the contextmanager decorators that did not have tail code.

EDIT: also, this makes the PR actually small again. All the other locations have no tail code. It's actually only that one.

@christianparpart christianparpart added this pull request to the merge queue Nov 3, 2023
Merged via the queue into frequenz-floss:v1.x.x with commit fdd18a9 Nov 3, 2023
@christianparpart christianparpart deleted the safe-contextmanagers branch November 3, 2023 10:13
@llucax llucax added this to the v1.0.0-rc3 milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llucax llucax llucax approved these changes

Assignees

@christianparpart christianparpart

Labels
part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)
Projects
Python SDK Roadmap
Status: Done
Milestone
v1.0.0-rc3
Development

Successfully merging this pull request may close these issues.

Add try/finally to decorated context managers
2 participants
@christianparpart @llucax