Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set resent_latest=True for BatteryPool.power_status's channels #743

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Set resent_latest=True for BatteryPool.power_status's channels #743

merged 4 commits into from
Oct 26, 2023

Conversation

shsms
Copy link
Contributor

@shsms shsms commented Oct 25, 2023 •
edited
Loading

Closes #740

shsms added 2 commits October 25, 2023 16:49
@shsms
Add set_resend_latest method to ChannelRegistry class
51e7198 
This would allow better control over the channels, where needed.

Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@shsms
Set resent_latest=True for BatteryPool.power_status's channels
f82b203 
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@shsms shsms requested a review from a team as a code owner October 25, 2023 14:55
@shsms shsms requested a review from llucax October 25, 2023 14:55
@github-actions github-actions bot added part:data-pipeline Affects the data pipeline part:actor Affects an actor ot the actors utilities (decorator, etc.) labels Oct 25, 2023
@shsms
Update RELEASE_NOTES.md
aa06a43 
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@github-actions github-actions bot added the part:docs Affects the documentation label Oct 25, 2023
daniel-zullo-frequenz
daniel-zullo-frequenz reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@daniel-zullo-frequenz daniel-zullo-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question and a cosmetic suggestion. Other than that LGTM

@shsms @daniel-zullo-frequenz
Update docstring in _channel_registry.py
e3cad5f 
Co-authored-by: daniel-zullo-frequenz <120166726+daniel-zullo-frequenz@users.noreply.github.com>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@shsms shsms added this pull request to the merge queue Oct 26, 2023
Merged via the queue into frequenz-floss:v1.x.x with commit 2a45ec0 Oct 26, 2023
@shsms shsms deleted the resend_latest branch October 26, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-zullo-frequenz daniel-zullo-frequenz daniel-zullo-frequenz approved these changes

@llucax llucax Awaiting requested review from llucax llucax is a code owner automatically assigned from frequenz-floss/python-sdk-team

Assignees
No one assigned
Labels
part:actor Affects an actor ot the actors utilities (decorator, etc.) part:data-pipeline Affects the data pipeline part:docs Affects the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow setting resend_latest = True for channels in the ChannelRegistry
2 participants
@shsms @daniel-zullo-frequenz