Replace obsolete types #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tool `pyupgrade` was used to modernize the code base
given that frequenz-SDK is already using python 3.11
as minimum version.
The tool was mainly used to replace obsolete types.
Just as a reference the tool was run with the following shell command:
```sh
find ./src ./benchmarks ./docs ./examples \
./tests -name '*.py' -exec pyupgrade --py311-plus {} \;
```
Also black and isort were both run to format the code base after
running pyupgrade.
Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
Most of the annotations from __future__ are no longer needed, except for the cases where there are circular dependencies, forward references, or when the type hint is used inside the class itself. Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
llucax
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tool
pyupgradewas used to modernize the code base given that frequenz-SDK is already using python 3.11 as minimum version. The tool was mainly used to replace obsolete types.Just as a reference the tool was run with the following shell command:
Also
blackandisortwere both run to format the code base after runningpyupgrade.Fixes #433