Add capacity, oldest and newest timestamp to moving window #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e367e2 to
8103652
Compare
39bfa84 to
92b8f20
Compare
|
@matthias-wende-frequenz Updated. |
|
Removing myself as a reviewer, as @matthias-wende-frequenz already picked up on it. |
| @@ -313,9 +352,9 @@ def __getitem__(self, key: SupportsIndex | datetime | slice) -> float | ArrayLik | |||
| key = slice(slice(key.start, key.stop).indices(self.__len__())) | |||
| elif isinstance(key.start, datetime) or isinstance(key.stop, datetime): | |||
| if key.start is None: | |||
| key = slice(self._buffer.time_bound_oldest, key.stop) | |||
| key = slice(self._buffer.oldest_timestamp, key.stop) | |||
There was a problem hiding this comment.
you can remove the ._buffer now ;)
There was a problem hiding this comment.
Didn't want to touch it since I am reworking this functionality at the moment for #214 where I remove this part. Also they are not exactly the same as they differ for empty arrays (which is not a concern here due to the check couple of lines above).
| @@ -173,11 +173,11 @@ def _timestamp_to_rel_index(self, timestamp: datetime) -> int: | |||
|
|
|||
| # distance between the input ts and the ts of oldest known samples (in samples) | |||
| dist_to_oldest = int( | |||
| (timestamp - self._buffer.time_bound_oldest) / self._sampling_period | |||
| (timestamp - self._buffer.oldest_timestamp) / self._sampling_period | |||
There was a problem hiding this comment.
same here. no need to access the property through the _buffer
matthias-wende-frequenz
previously approved these changes
Aug 29, 2023
|
@matthias-wende-frequenz Removed the oldest timestamp method. |
|
Reworked based on #641. Blocking until the above is merged. |
The capacity is the maximum number of values that the moving window can hold. Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com>
Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com>
Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com>
Signed-off-by: cwasicki <126617870+cwasicki@users.noreply.github.com>
|
Rebased |
matthias-wende-frequenz
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The capacity of the moving window is exposed, which is the maximum number of values that the moving window can hold.
Also the oldest and newest timestamps are exposed by the moving window.