-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure dependabot to automated version updates #268
Configure dependabot to automated version updates #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any examples of how this work in your fork to understand better how it works?
A few other questions:
- Will this propose only security updates or will also propose updates when any dependency gets a new version released?
- If it is the second, will propose updates only for minor updates? Major too? IIRC there were options to control this.
- Will this run on all branches or just the default branch? If the second, can it be enabled to older versions also can get security updates?
Yes, you can see some PR examples here |
The securities update are managed/configured in the settings of the repo, see image below. We only need to ensure/check security updates are enabled The configuration file will take care only of version updates |
The current configuration will run only on the default branch. Though we can set manually another branch using |
75d19b9
to
931f107
Compare
Added the supported branches so that security updates are automatically applied on those branches. Unfortunately I couldn't use anchor and aliases in the YAML for dependabot as they not supported due to security issues with the yaml parser for some ecosystems. Thus you might notice there are code duplication/redundancy in the configuration |
I see, so we have no control over security updates? Like frequency, labels, etc? I thought there was some config possible with the yaml file. |
Do you know if we can use wildcards? I would enable it for all branches. We can just remove unmaintained branches so they don't get PRs, this will clearly indicate which branches are maintained and which aren't anymore. |
A few comments:
|
I'm afraid we cannot use wildcards either in the current state :( |
No, that was because I accidentally set version updates for stable branches (non-default) instead of only security updates.
I'm afraid we cannot configure that or I haven´t found it yet how to do it. Anyway let's please discuss it in a call |
OK, we met and here is the summary of what we talked about:
|
931f107
to
ba9f9c7
Compare
Thanks Luca for the nice write up! |
ba9f9c7
to
b1a6fb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
Last comment (optional): We don't really need to set the reviewers
here, as we already have it in the CODEOWNERS
file, it's sort of redundant.
Signed-off-by: daniel-zullo-frequenz <120166726+daniel-zullo-frequenz@users.noreply.github.com>
Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
The SDK does not really need to support a range of version for dev/test dependencies. This will maximize the reproducibility of builds and dependabot will open PRs to let us know when there are new versions of the dependencies so that we can easily bump them. Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
b1a6fb2
to
83489c9
Compare
I agree and I've already removed reviewers. |
Add dependabot configuration file to automate version updates for pip dependencies and github actions.
The security updates needs to be checked/enabled from the settings in the repo.
Fixes: #242