Skip to content

Commit

Permalink
Define regular attributes with default values
Browse files Browse the repository at this point in the history
Pylint was complaining about documentation (pointless-string-statement)
for class attributes defined in the `__post_init__` method which
is not the recommended way to define attributes.

Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
  • Loading branch information
daniel-zullo-frequenz committed Sep 5, 2023
1 parent 918e140 commit 2763bc5
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions src/frequenz/sdk/actor/power_distributing/_battery_status.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,16 +83,18 @@ class _BlockingStatus:
max_duration_sec: float
"""The maximum blocking duration (in seconds)."""

last_blocking_duration_sec: float = 0.0
"""Last blocking duration (in seconds)."""

blocked_until: datetime | None = None
"""Until when the battery is blocked."""

def __post_init__(self) -> None:
assert self.min_duration_sec <= self.max_duration_sec, (
f"Minimum blocking duration ({self.min_duration_sec}) cannot be greater "
f"than maximum blocking duration ({self.max_duration_sec})"
)
self.last_blocking_duration_sec: float = self.min_duration_sec
"""Last blocking duration (in seconds).""" # pylint: disable=pointless-string-statement

self.blocked_until: Optional[datetime] = None
"""Until when battery is blocked.""" # pylint: disable=pointless-string-statement
self.last_blocking_duration_sec = self.min_duration_sec

def block(self) -> float:
"""Block battery.
Expand Down

0 comments on commit 2763bc5

Please sign in to comment.