Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: storage migration #2236

Merged
merged 3 commits into from
Dec 10, 2024
Merged

cleanup: storage migration #2236

merged 3 commits into from
Dec 10, 2024

Conversation

aramikm
Copy link
Collaborator

@aramikm aramikm commented Dec 9, 2024 •
edited
Loading

Goal

The goal of this PR is to remove extra migrations

Related to #2227

Discussion

  • keeping the MigrationPageIndex storage around for future use. Removing it requires another migration which is not justified currently.

Checklist

  • Spec version incremented?

@aramikm aramikm requested a review from wilwade as a code owner December 9, 2024 22:02
@aramikm aramikm changed the title cleanup: storeage migration cleanup: storage migration Dec 9, 2024
wilwade
wilwade approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Any other migrations we need to remove while we are at it?

@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
pallets/capacity/src/lib.rs 94.84% <ø> (ø)
pallets/messages/src/lib.rs 81.41% <ø> (ø)
pallets/schemas/src/lib.rs 82.02% <ø> (ø)
pallets/stateful-storage/src/lib.rs 79.22% <ø> (-2.96%) ⬇️
pallets/time-release/src/lib.rs 86.44% <ø> (ø)

... and 2 files with indirect coverage changes

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Dec 9, 2024
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Dec 10, 2024
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Dec 10, 2024
shannonwells
shannonwells approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1300+ lines removed, I like that.

@aramikm aramikm merged commit 407b520 into main Dec 10, 2024
30 checks passed
@aramikm aramikm deleted the cleanup_storage_migration branch December 10, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeCap08055 JoeCap08055 JoeCap08055 approved these changes

@saraswatpuneet saraswatpuneet saraswatpuneet approved these changes

@mattheworris mattheworris mattheworris approved these changes

@wilwade wilwade wilwade approved these changes

@shannonwells shannonwells shannonwells approved these changes

@enddynayn enddynayn Awaiting requested review from enddynayn

Assignees
No one assigned
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aramikm @shannonwells @wilwade @mattheworris @saraswatpuneet @JoeCap08055