Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passkeys: cleanup tests #2068

Merged
merged 1 commit into from
Jul 11, 2024
Merged

passkeys: cleanup tests #2068

merged 1 commit into from
Jul 11, 2024

Conversation

aramikm
Copy link
Collaborator

@aramikm aramikm commented Jul 10, 2024

Goal

The goal of this PR is to clean up tests and use Builder pattern to setup the test

Related to #2032

Checklist

  • Tests Updated

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor!

}

#[test]
fn proxy_call_with_signed_origin_should_fail() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful! 👍

Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 clean!

@aramikm aramikm merged commit 3ebbb71 into main Jul 11, 2024
27 checks passed
@aramikm aramikm deleted the refactor_tests branch July 11, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants