passkey: nonce check #2039
Merged
passkey: nonce check #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
|
JoeCap08055
reviewed
Jun 25, 2024
enddynayn
reviewed
Jun 25, 2024
enddynayn
reviewed
Jun 25, 2024
enddynayn
reviewed
Jun 27, 2024
| impl<T: Config> ValidateUnsigned for Pallet<T> { | ||
| impl<T: Config> ValidateUnsigned for Pallet<T> | ||
| where | ||
| <T as frame_system::Config>::RuntimeCall: Dispatchable<Info = DispatchInfo>, |
enddynayn
reviewed
Jun 27, 2024
enddynayn
reviewed
Jun 27, 2024
aramikm
commented
Jun 27, 2024
| benchmarks! { | ||
| proxy { | ||
| let caller: T::AccountId = whitelisted_caller(); | ||
| where_clause { where <T as frame_system::Config>::RuntimeCall: Dispatchable<Info = DispatchInfo> } |
There was a problem hiding this comment.
@enddynayn This one liner missing was the main issue
mattheworris
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to verify that the nonce is correct for the account_id and increase the nonce. And to restrict the transactions that can be called inside a passkey
Closes #2030
Checklist