Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): refactor messages #198

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Conversation

enddynayn
Copy link
Collaborator

Refactor "add" extrinsic by creating a helper function, add_messages,
that is used to store messages.

issue-143

@enddynayn enddynayn marked this pull request as ready for review June 21, 2022 21:17
@enddynayn enddynayn force-pushed the issue-143-multiple-messages-refactor branch from 4799627 to 231585f Compare June 21, 2022 21:23
@aramikm aramikm self-requested a review June 21, 2022 21:32
Copy link
Collaborator

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Refactor "add" extrinsic by creating a helper function, add_messages,
that is used to store messages.

issue-143
@enddynayn enddynayn force-pushed the issue-143-multiple-messages-refactor branch from 231585f to 03a2aca Compare June 21, 2022 21:38
@enddynayn enddynayn merged commit a82f245 into main Jun 21, 2022
@enddynayn enddynayn deleted the issue-143-multiple-messages-refactor branch June 21, 2022 22:42
@aramikm aramikm mentioned this pull request Oct 25, 2023
5 tasks
aramikm added a commit that referenced this pull request Nov 10, 2023
# Goal
The goal of this PR is to propose and implement messages v2 compatible
with PoV

Closes #198 

# Discussion
- Refactored Messages to minimize used PoV
- Added storage migration (single block)

# Migration Details
- Based on data used in rococo and main-net and calculations we don't
need to do a multi-block migration. (only around 15%) of the block is
being used.
- Was not able to test with upgrading on local due to getting errors
when running relay nodes
- Was able to successfully run try-run-time cli tool against rococo

# Checklist
- [x] Chain spec updated
- [x] Design doc(s) updated
- [x] Tests added
- [x] Benchmarks added
- [x] Weights updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants