Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update image paths in design documentation #1878

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix: Update image paths in design documentation #1878

merged 1 commit into from
Feb 13, 2024

Conversation

mattheworris
Copy link
Collaborator

Goal

The goal of this PR is move Design Docs file from LibertyDSNP/DesignDocs to the ./docs/images folder and update the references in the ./designdocs and ./README.md

Checklist

  • Chain spec updated
  • Custom RPC OR Runtime API added/changed? Updated js/api-augment.
  • Design doc(s) updated
  • Tests added
  • Benchmarks added
  • Weights updated

@mattheworris mattheworris requested a review from a team February 13, 2024 22:29
@mattheworris mattheworris self-assigned this Feb 13, 2024
@mattheworris mattheworris requested a review from p5150j February 13, 2024 22:30
enddynayn
enddynayn approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goals 🚀

@mattheworris mattheworris merged commit d4d450d into main Feb 13, 2024
27 checks passed
@mattheworris mattheworris deleted the chore/move-design-images branch February 13, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saraswatpuneet saraswatpuneet saraswatpuneet approved these changes

@enddynayn enddynayn enddynayn approved these changes

@p5150j p5150j p5150j approved these changes

@wilwade wilwade Awaiting requested review from wilwade wilwade is a code owner

Assignees

@mattheworris mattheworris

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattheworris @p5150j @enddynayn @saraswatpuneet